Viewing a response to: @mahdiyari/2nsy4k-steemauto-backend-improvement
Thanks for the contribution, @mahdiyari! Did you know a lot about JavaScript before you created SteemAuto with PHP? If not, then how did you go about learning it (just curious)? As for your code, everything looks good, but there are maybe some minor improvements that could be made. For example, I noticed that you have a lot of nested if statements in places, which could be prevented by switching them around. Also, there are a lot of comments everywhere, which is fine. However, sometimes it's pretty obvious what the code does, but there are still comments explaining it. In my opinion it would be better to leave the comments for the difficult to understand code and function declarations/docstrings, but that is up to you of course. Looking forward to seeing more of your contributions in the future! --- Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2212222). ---- Need help? Write a ticket on https://support.utopian.io/. Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
| post_id | 62,599,235 |
|---|---|
| author | amosbastian |
| permlink | re-mahdiyari-2nsy4k-steemauto-backend-improvement-20180916t144910759z |
| category | utopian-io |
| json_metadata | {"users":["mahdiyari"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/2212222","https:\/\/support.utopian.io\/","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"tags":["utopian-io"],"app":"steemit\/0.1"} |
| created | 2018-09-16 14:49:12 |
| last_update | 2018-09-16 14:49:12 |
| depth | 1 |
| children | 2 |
| net_rshares | 9,614,698,288,261 |
| last_payout | 2018-09-23 14:49:12 |
| cashout_time | 1969-12-31 23:59:59 |
| total_payout_value | 8.777 SBD |
| curator_payout_value | 2.854 SBD |
| pending_payout_value | 0.000 SBD |
| promoted | 0.000 SBD |
| body_length | 1,305 |
| author_reputation | 174,225,255,912,876 |
| root_title | "Steemauto - backend improvement" |
| beneficiaries | [] |
| max_accepted_payout | 1,000,000.000 SBD |
| percent_steem_dollars | 10,000 |
| author_curate_reward | "" |
| voter | weight | wgt% | rshares | pct | time |
|---|---|---|---|---|---|
| mahdiyari | 0 | 47,500,955,767 | 32% | ||
| espoem | 0 | 18,529,985,671 | 15% | ||
| utopian-io | 0 | 9,515,722,328,878 | 6.3% | ||
| organicgardener | 0 | 4,692,075,946 | 25% | ||
| reazuliqbal | 0 | 9,550,118,400 | 10% | ||
| hakancelik | 0 | 6,700,928,354 | 100% | ||
| mightypanda | 0 | 11,662,167,069 | 20% | ||
| mops2e | 0 | 339,728,176 | 10% |
Thanks for your review Yes. I was a little lazy about that if statements. I just wanted to finish coding. (I will try to improve that codes in the coming update but I prefer to add new features and leave that minor contributions to other users to get a reward by contributing) Actually, I try to explain what is the purpose of using a code (function, and etc) I started using comments when I had to check my old codes! (a hard job) Thanks again for your review:) *** Let's answer your first question: No. I learned a lot after developing Steemauto. I try to learn things by experiment and I learned Javascript by using it in my projects. I think my first server-side app was voter.js ([GitHub](https://github.com/mahdiyari/voter.js)) Then I coded the server-side operations of steemauto with Javascript (listening blocks, upvoting, and etc) and I changed those operations many times (really many times) Then I started learning AngularJS and built some local applications with that for using in the Steem blockchain (just for practice) Then I found ReactJS! I used React and again developed some applications about Steem (just for practice) Finally, I moved to Angular v6, Typescript, es6, and etc. It is a long story. Thanks for your time:)
| post_id | 62,607,013 |
|---|---|
| author | mahdiyari |
| permlink | re-amosbastian-re-mahdiyari-2nsy4k-steemauto-backend-improvement-20180916t164552823z |
| category | utopian-io |
| json_metadata | {"tags":["utopian-io"],"app":"steemit\/0.1","links":["https:\/\/github.com\/mahdiyari\/voter.js"]} |
| created | 2018-09-16 16:45:57 |
| last_update | 2018-09-16 16:45:57 |
| depth | 2 |
| children | 0 |
| net_rshares | 0 |
| last_payout | 2018-09-23 16:45:57 |
| cashout_time | 1969-12-31 23:59:59 |
| total_payout_value | 0.000 SBD |
| curator_payout_value | 0.000 SBD |
| pending_payout_value | 0.000 SBD |
| promoted | 0.000 SBD |
| body_length | 1,240 |
| author_reputation | 50,504,878,810,975 |
| root_title | "Steemauto - backend improvement" |
| beneficiaries | [] |
| max_accepted_payout | 1,000,000.000 SBD |
| percent_steem_dollars | 10,000 |
Thank you for your review, @amosbastian! So far this week you've reviewed 12 contributions. Keep up the good work!
| post_id | 62,975,583 |
|---|---|
| author | utopian-io |
| permlink | re-re-mahdiyari-2nsy4k-steemauto-backend-improvement-20180916t144910759z-20180921t165343z |
| category | utopian-io |
| json_metadata | {"app":"beem\/0.19.42"} |
| created | 2018-09-21 16:53:45 |
| last_update | 2018-09-21 16:53:45 |
| depth | 2 |
| children | 0 |
| net_rshares | 0 |
| last_payout | 2018-09-28 16:53:45 |
| cashout_time | 1969-12-31 23:59:59 |
| total_payout_value | 0.000 SBD |
| curator_payout_value | 0.000 SBD |
| pending_payout_value | 0.000 SBD |
| promoted | 0.000 SBD |
| body_length | 115 |
| author_reputation | 152,913,012,544,965 |
| root_title | "Steemauto - backend improvement" |
| beneficiaries | [] |
| max_accepted_payout | 1,000,000.000 SBD |
| percent_steem_dollars | 10,000 |