RE: CadEditor. Block configs for 16 games by helo

Viewing a response to: @pinkwonder/cadeditor-block-configs-for-16-games-1550256272047

utopian-io · @helo · Feb 15 '19

$9.99

- Great post with lots of images and code samples.
- There is not enough comments in the code
- While searching for comments `//`It's easy to see that a lot of the code is repetitive.  Is there no way to make this more modular?
- Machine generated code is not well looked upon for contributions.  If it is needed, perhaps you could put it in a separate pull request and not include that in your utopian articles. 

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/1-3-1-1-1-1-3-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)

👍 utopian-io, amosbastian, jaff8, espoem, codingdefined, yuxi, yff, reazuliqbal, tata-natana, emrebeyler, aydant, quenty, cheneats, nimloth, nenya, nijn

`post_id`	70,206,449
`author`	helo
`permlink`	re-pinkwonder-cadeditor-block-configs-for-16-games-1550256272047-20190215t230251330z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/1-3-1-1-1-1-3-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"}
`created`	2019-02-15 23:02:51
`last_update`	2019-02-15 23:02:51
`depth`	1
`children`	2
`net_rshares`	19,344,147,804,475
`last_payout`	2019-02-22 23:02:51
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	7.588 SBD
`curator_payout_value`	2.400 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	863
`author_reputation`	119,612,833,307,875
`root_title`	"CadEditor. Block configs for 16 games"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000
`author_curate_reward`	""

properties (23)vote details (16)

voter	rshares	pct
yuxi	23,196,221,301	100%
codingdefined	27,807,142,227	20%
espoem	29,126,173,865	15%
utopian-io	19,051,495,015,712	13.66%
jaff8	58,986,176,373	28.66%
emrebeyler	5,806,721,556	1%
cheneats	1,641,241,613	6%
aydant	5,403,857,182	50%
amosbastian	79,916,619,201	28.66%
nenya	942,788,240	95%
reazuliqbal	18,237,245,579	10%
tata-natana	16,051,353,379	75%
nijn	448,505,568	95%
quenty	4,233,143,083	71.25%
nimloth	1,137,142,185	95%
yff	19,718,457,411	100%

@pinkwonder · Feb 15 '19

Thanks for the review.
>While searching for comments //It's easy to see that a lot of the code is repetitive. Is there no way to make this more modular?

Some of the configs created by users, who are not familiar with programming. I checked and validated the correctness of configs, but not improved the quality of the code. So now I have a problem with it - I think about how to improve the quality of hundred of configs. I working on it.

>Machine generated code is not well looked upon for contributions. If it is needed, perhaps you could put it in a separate pull request and not include that in your utopian articles.

Which code is looked as machine-generated for you? :) Unfortunately, all commits are hand-made for now.

properties (22)

`post_id`	70,206,830
`author`	pinkwonder
`permlink`	re-helo-re-pinkwonder-cadeditor-block-configs-for-16-games-1550256272047-20190215t231254868z
`category`	utopian-io
`json_metadata`	{"community":"busy","app":"busy\/2.5.6","format":"markdown","tags":["utopian-io"],"users":[],"links":[]}
`created`	2019-02-15 23:12:54
`last_update`	2019-02-15 23:12:54
`depth`	2
`children`	0
`net_rshares`	0
`last_payout`	2019-02-22 23:12:54
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 SBD
`curator_payout_value`	0.000 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	728
`author_reputation`	12,334,203,545,676
`root_title`	"CadEditor. Block configs for 16 games"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000

@utopian-io · Feb 18 '19

Thank you for your review, @helo! Keep up the good work!

properties (22)

`post_id`	70,301,140
`author`	utopian-io
`permlink`	re-re-pinkwonder-cadeditor-block-configs-for-16-games-1550256272047-20190215t230251330z-20190218t043253z
`category`	utopian-io
`json_metadata`	{"app":"beem\/0.20.17"}
`created`	2019-02-18 04:32:54
`last_update`	2019-02-18 04:32:54
`depth`	2
`children`	0
`net_rshares`	0
`last_payout`	2019-02-25 04:32:54
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 SBD
`curator_payout_value`	0.000 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	56
`author_reputation`	152,913,012,544,965
`root_title`	"CadEditor. Block configs for 16 games"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000