RE: WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019 by justyy

View this thread on steempeak.com

Viewing a response to: @sagescrub/woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019

· @justyy ·
$12.59
Thank you for your contribution.

1. I would suggest you manage your commits via Pull Requests i.e. you can create a branch and submit a PR to merge to your master branch - this way the branch will contain more descriptive commits instead of single big commit.
2. You three exchanges could all extend to a interface which has a `query_rates` function signature. So you code will be much more organized later when you want to switch exchanges.
3. You might want to look at the APIs from `coinmarketcap` that can be used to convert between any two currencies/fiat - not use USD/BTC, BTC/STEEM, or BTC/SBD
4. Getting medians may be better than averaging the rates from exchanges . Sometimes, one exchange may show up abnormal rates because of pumping.

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-2-2-2-2-4-2-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , , , , , , , , , ,
properties (23)
post_id71,621,122
authorjustyy
permlinkre-sagescrub-woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019-20190317t203744115z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/2-2-2-2-2-4-2-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"}
created2019-03-17 20:37:45
last_update2019-03-17 20:37:45
depth1
children2
net_rshares18,527,749,292,592
last_payout2019-03-24 20:37:45
cashout_time1969-12-31 23:59:59
total_payout_value9.541 SBD
curator_payout_value3.050 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length1,198
author_reputation2,057,469,156,047,835
root_title"WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
author_curate_reward""
vote details (22)
@sagescrub ·
Hi @justyy. Thank you so much, your comment is packed with helpful suggestions. I appreciate them all and you got me thinking about a few things from different angles, so I appreciate that!  

RE #4 I am curious if you are implying calculating median rates weighted by volume or simply taking the middle rate? Definitely want to avoid pumping rates if it is possible, so I value your feedback. 

Actually that is related to the reason why we are choosing trusted exchanges vs CoinMarketCap - some people do not trust coinmarketcap to always be an accurate representation. But after reading your comment I can see the value in offering it as a choice, or perhaps treating it as another exchanges from which to choose the median.
properties (22)
post_id71,686,164
authorsagescrub
permlinkre-justyy-re-sagescrub-woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019-20190319t042910772z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"users":["justyy"],"app":"steemit\/0.1"}
created2019-03-19 04:29:12
last_update2019-03-19 04:29:12
depth2
children0
net_rshares0
last_payout2019-03-26 04:29:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length727
author_reputation27,331,701,354,422
root_title"WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
@utopian-io ·
Thank you for your review, @justyy! Keep up the good work!
properties (22)
post_id71,744,575
authorutopian-io
permlinkre-re-sagescrub-woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019-20190317t203744115z-20190320t101701z
categoryutopian-io
json_metadata{"app":"beem\/0.20.17"}
created2019-03-20 10:17:03
last_update2019-03-20 10:17:03
depth2
children0
net_rshares0
last_payout2019-03-27 10:17:03
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length58
author_reputation152,913,012,544,965
root_title"WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000