Viewing a response to: @sagescrub/woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019
Thank you for your contribution. 1. I would suggest you manage your commits via Pull Requests i.e. you can create a branch and submit a PR to merge to your master branch - this way the branch will contain more descriptive commits instead of single big commit. 2. You three exchanges could all extend to a interface which has a `query_rates` function signature. So you code will be much more organized later when you want to switch exchanges. 3. You might want to look at the APIs from `coinmarketcap` that can be used to convert between any two currencies/fiat - not use USD/BTC, BTC/STEEM, or BTC/SBD 4. Getting medians may be better than averaging the rates from exchanges . Sometimes, one exchange may show up abnormal rates because of pumping. Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-2-2-2-2-4-2-). ---- Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
post_id | 71,621,122 |
---|---|
author | justyy |
permlink | re-sagescrub-woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019-20190317t203744115z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/2-2-2-2-2-4-2-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"} |
created | 2019-03-17 20:37:45 |
last_update | 2019-03-17 20:37:45 |
depth | 1 |
children | 2 |
net_rshares | 18,527,749,292,592 |
last_payout | 2019-03-24 20:37:45 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 9.541 SBD |
curator_payout_value | 3.050 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 1,198 |
author_reputation | 2,057,469,156,047,835 |
root_title | "WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
happyukgo | 0 | 512,855,704 | 25% | ||
lordneroo | 0 | 44,746,017,837 | 50% | ||
codingdefined | 0 | 28,897,694,195 | 20% | ||
superbing | 0 | 2,568,525,367 | 25% | ||
dailyfortune | 0 | 36,623,369 | 25% | ||
espoem | 0 | 28,956,797,458 | 15% | ||
dailystats | 0 | 7,500,855,613 | 25% | ||
utopian-io | 0 | 18,219,136,923,217 | 12.93% | ||
jaff8 | 0 | 41,625,943,857 | 18.94% | ||
lostmine27 | 0 | 11,478,965,829 | 25% | ||
sagescrub | 0 | 36,645,665,430 | 100% | ||
amosbastian | 0 | 60,136,052,475 | 18.94% | ||
penghuren | 0 | 507,484,527 | 100% | ||
dailychina | 0 | 7,098,890,260 | 25% | ||
reazuliqbal | 0 | 13,113,344,821 | 8% | ||
turtlegraphics | 0 | 2,444,977,341 | 25% | ||
ulockblock | 0 | 11,280,798,692 | 3.62% | ||
witnesstools | 0 | 2,357,375,174 | 25% | ||
ilovecoding | 0 | 2,337,533,448 | 25% | ||
curbot | 0 | 2,496,638,362 | 100% | ||
steemfuckeos | 0 | 1,525,981,300 | 25% | ||
ascorphat | 0 | 2,343,348,316 | 2.5% |
Hi @justyy. Thank you so much, your comment is packed with helpful suggestions. I appreciate them all and you got me thinking about a few things from different angles, so I appreciate that! RE #4 I am curious if you are implying calculating median rates weighted by volume or simply taking the middle rate? Definitely want to avoid pumping rates if it is possible, so I value your feedback. Actually that is related to the reason why we are choosing trusted exchanges vs CoinMarketCap - some people do not trust coinmarketcap to always be an accurate representation. But after reading your comment I can see the value in offering it as a choice, or perhaps treating it as another exchanges from which to choose the median.
post_id | 71,686,164 |
---|---|
author | sagescrub |
permlink | re-justyy-re-sagescrub-woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019-20190319t042910772z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"users":["justyy"],"app":"steemit\/0.1"} |
created | 2019-03-19 04:29:12 |
last_update | 2019-03-19 04:29:12 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2019-03-26 04:29:12 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 727 |
author_reputation | 27,331,701,354,422 |
root_title | "WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
Thank you for your review, @justyy! Keep up the good work!
post_id | 71,744,575 |
---|---|
author | utopian-io |
permlink | re-re-sagescrub-woocommerce-steem-payment-method-now-queries-3-exchanges-for-steem-sbd-prices-17-march-2019-20190317t203744115z-20190320t101701z |
category | utopian-io |
json_metadata | {"app":"beem\/0.20.17"} |
created | 2019-03-20 10:17:03 |
last_update | 2019-03-20 10:17:03 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2019-03-27 10:17:03 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 58 |
author_reputation | 152,913,012,544,965 |
root_title | "WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |