![finally.png](https://ipfs.busy.org/ipfs/QmSEtAbbrT4U3Qdy2tHkQNW1GfHJXUGiqmbEj57iDFHJoT) <center>*https://finallycomments.com*</center> > What is Finally Comments? Finally Comments is an embeddable comments system powered by the Steem blockchain. The aim of this project is to promote the Steem ecosystem by breaking the comments system out of the walls of Steem based apps replacing popular comments systems like Disqus & Facebook comments plugin. - - - Today I have finally publish a number of fixes to both the Finally platform and the Javascript library. These issues have been hanging around for a couple of months. If you have followed other parts of my blog you'll know I was cycling across Europe. I have also been a little pre-occupied getting [https://finally.network](https://finally.network) started. #### Repository Platform - https://github.com/code-with-sam/finallycomments NPM Package/JS Library - https://github.com/code-with-sam/npm-finallycomments ### Library Fixes - [/npm-finallycomments/pull/8](https://github.com/code-with-sam/npm-finallycomments/pull/8) ![screely-1538941659579.png](https://ipfs.busy.org/ipfs/QmUidrbLKCDZShz9YbrxW3MJvqUcJdMR3vrHRhA6B5hEDq) <center>*Universal embed code in [Finally Dashboard](https://finallycomments.com/dashboard)* </center> The primary Issue I started digging into was with the *universal embed code* . When initialising the javascript library it should create an iframe using the `data-id` attribute of the embed code. It took a little investigating to realise the url was being deconstructed and incorrect reconstructed again. Although this fix was fairly straight forward by creating a ternary statement([src/index.js#53](https://github.com/code-with-sam/npm-finallycomments/pull/8/commits/426a9dd20c97876b8302cec7cdc415c7154e8c08#diff-1fdf421c05c1140f6d71444ea2b27638R53)) it lead to me discovering a number of other issues with the library. The initialise function had been working correctly but using any other external functions when including the library directly failed. The exposed `finallycomments` object was incorrect. Correctly assign export object instead of finally system to call external functions ([/src/index.js/#131](https://github.com/code-with-sam/npm-finallycomments/pull/8/commits/426a9dd20c97876b8302cec7cdc415c7154e8c08#diff-1fdf421c05c1140f6d71444ea2b27638R131)) While working through these fixes I oppted to add a small page that worked directly with the local library and a local version of FinallyComments platform. `/test/` have placeholders to check each dynamic function and test the three types of embeds. Should be replaced with some programatic tests but this is useful for debugging. [ testing example functions](https://github.com/code-with-sam/npm-finallycomments/pull/8/commits/dd6c1e0a1be1e41d05c39c9991de40d7cbc44e11) Threads generated via the API or Finally dashboard are created as a comment under the @finallycomments account. When displaying these comment threads the top level comment is hidden as it is a placeholder only. The settings for `generated` is checked to determine this. These settings values are added as html data-attributes and should therefore be checked as a string and not a boolean. ### Platform Fixes [/finallycomments/pull/47](https://github.com/code-with-sam/finallycomments/pull/47) When working on fixes for the platform I found I had completely missed passing the repsonse object to the relevant functions. Looking at the previous commits it seems I refacoted a set of code into a module without realising the variable scope for the response object would change. Simple fix although it always feels incorrect to pass the response object around. Perhaps the relevant data should be returned to the correct route instead [3f20f5205](https://github.com/code-with-sam/finallycomments/pull/47/commits/3f20f52053637df232c1d0619425829065c651e4) Next I found issues with the beneficiary feature. First custom threads breaking when no beneficiaries were selected. Second, incorrect classes on the dashboard beneficiary inputs caused empty variables to be submitted. - [Optional Beneficiaries](https://github.com/code-with-sam/finallycomments/pull/47/commits/ea4bd71e65f6d9c7fc9fd563dde89cc10898b516) - [Add correct classes](https://github.com/code-with-sam/finallycomments/pull/47/commits/1147a8f3ade68f1b6ffc49996ad8b24a25c350a0) There were a few smaller updates aded to keep FinallyComments running. Thanks for checking this update. If you encounter any other issues feel free to submit them via Github or directly to me on Discord [sambillingham#7927]
post_id | 63,836,260 | ||||||
---|---|---|---|---|---|---|---|
author | sambillingham | ||||||
permlink | finally-comments-npm-library-platform-fixes-1538948648670 | ||||||
category | utopian-io | ||||||
json_metadata | {"image":["https:\/\/ipfs.busy.org\/ipfs\/QmSEtAbbrT4U3Qdy2tHkQNW1GfHJXUGiqmbEj57iDFHJoT"],"users":["finallycomments"],"format":"markdown","tags":["utopian-io","development","finallycomments","sndbox","finallynetwork"],"app":"steemit\/0.1","links":["https:\/\/finallycomments.com","https:\/\/finally.network","https:\/\/github.com\/code-with-sam\/finallycomments","https:\/\/github.com\/code-with-sam\/npm-finallycomments","https:\/\/github.com\/code-with-sam\/npm-finallycomments\/pull\/8","https:\/\/finallycomments.com\/dashboard","https:\/\/github.com\/code-with-sam\/npm-finallycomments\/pull\/8\/commits\/426a9dd20c97876b8302cec7cdc415c7154e8c08#diff-1fdf421c05c1140f6d71444ea2b27638R53","https:\/\/github.com\/code-with-sam\/npm-finallycomments\/pull\/8\/commits\/426a9dd20c97876b8302cec7cdc415c7154e8c08#diff-1fdf421c05c1140f6d71444ea2b27638R131","https:\/\/github.com\/code-with-sam\/npm-finallycomments\/pull\/8\/commits\/dd6c1e0a1be1e41d05c39c9991de40d7cbc44e11","https:\/\/github.com\/code-with-sam\/finallycomments\/pull\/47","https:\/\/github.com\/code-with-sam\/finallycomments\/pull\/47\/commits\/3f20f52053637df232c1d0619425829065c651e4","https:\/\/github.com\/code-with-sam\/finallycomments\/pull\/47\/commits\/ea4bd71e65f6d9c7fc9fd563dde89cc10898b516","https:\/\/github.com\/code-with-sam\/finallycomments\/pull\/47\/commits\/1147a8f3ade68f1b6ffc49996ad8b24a25c350a0"]} | ||||||
created | 2018-10-07 21:44:09 | ||||||
last_update | 2018-10-08 06:48:42 | ||||||
depth | 0 | ||||||
children | 5 | ||||||
net_rshares | 27,231,833,852,648 | ||||||
last_payout | 2018-10-14 21:44:09 | ||||||
cashout_time | 1969-12-31 23:59:59 | ||||||
total_payout_value | 29.132 SBD | ||||||
curator_payout_value | 9.871 SBD | ||||||
pending_payout_value | 0.000 SBD | ||||||
promoted | 0.000 SBD | ||||||
body_length | 4,615 | ||||||
author_reputation | 34,851,559,982,476 | ||||||
root_title | "Finally Comments NPM Library + Platform - Fixes" | ||||||
beneficiaries |
| ||||||
max_accepted_payout | 100,000.000 SBD | ||||||
percent_steem_dollars | 10,000 | ||||||
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
bryan-imhoff | 0 | 100,872,155,242 | 50% | ||
mcsvi | 0 | 160,334,793,888 | 100% | ||
sambillingham | 0 | 18,739,405,902 | 100% | ||
jamzed | 0 | 35,097,800,864 | 100% | ||
hansikhouse | 0 | 8,834,442,608 | 25% | ||
voronoi | 0 | 24,832,967,980 | 50% | ||
dayleeo | 0 | 89,126,631,999 | 100% | ||
da-dawn | 0 | 2,485,759,587 | 7% | ||
heriafriadiaka | 0 | 347,769,687 | 50% | ||
miniature-tiger | 0 | 124,371,300,736 | 100% | ||
erb | 0 | 16,751,758,574 | 50% | ||
cryptastic | 0 | 2,602,959,690 | 10% | ||
luvabi | 0 | 6,664,414,980 | 25% | ||
bearone | 0 | 633,802,126 | 1% | ||
gokulnk | 0 | 20,640,757,376 | 100% | ||
jayna | 0 | 2,696,760,824 | 7.5% | ||
roxane | 0 | 102,848,340,346 | 5% | ||
carrotcake | 0 | 1,949,802,408 | 5% | ||
klynic | 0 | 543,569,681 | 10% | ||
coloringiship | 0 | 4,329,814,937 | 12.5% | ||
sndbox | 0 | 5,663,252,591,454 | 50% | ||
doughtaker | 0 | 24,758,191,077 | 100% | ||
molometer | 0 | 66,828,448,978 | 100% | ||
codingdefined | 0 | 3,962,297,222 | 5% | ||
leotrap | 0 | 2,398,668,540 | 5% | ||
somethingburger | 0 | 4,539,128,284 | 50% | ||
dayoung | 0 | 12,895,744,078 | 25% | ||
normalbro | 0 | 17,623,245,669 | 25% | ||
espoem | 0 | 22,070,108,582 | 20% | ||
playitforward | 0 | 18,503,453,080 | 15% | ||
imaginedragon | 0 | 705,445,549 | 12.5% | ||
vladimir-simovic | 0 | 89,248,096,982 | 75% | ||
utopian-io | 0 | 20,056,519,794,704 | 13.83% | ||
cryptonik | 0 | 272,679,235 | 100% | ||
scuzzy | 0 | 185,607,258 | 2.5% | ||
berkaytekinsen | 0 | 937,272,776 | 50% | ||
jeffbernst | 0 | 2,741,129,707 | 100% | ||
richardbmx | 0 | 2,920,816,169 | 100% | ||
sireh | 0 | 4,482,132,233 | 12.5% | ||
aidnessanchez | 0 | 333,769,438 | 25% | ||
sagor5828 | 0 | 156,808,030 | 25% | ||
flashfiction | 0 | 1,513,852,851 | 50% | ||
aussieninja | 0 | 36,301,474,286 | 80% | ||
camillius | 0 | 186,943,900 | 25% | ||
amosbastian | 0 | 59,446,985,575 | 73.75% | ||
carn | 0 | 1,464,569,336 | 100% | ||
tdre | 0 | 13,900,302,096 | 100% | ||
jjay | 0 | 414,128,421 | 100% | ||
oups | 0 | 50,881,026,170 | 100% | ||
adamzi | 0 | 1,844,588,594 | 25% | ||
deejee | 0 | 99,427,566 | 25% | ||
pcusine | 0 | 2,715,818,748 | 33% | ||
soufiani | 0 | 98,297,531 | 1% | ||
michealkey | 0 | 315,673,074 | 25% | ||
holger80 | 0 | 43,498,134,825 | 25% | ||
debruyne844 | 0 | 99,334,761 | 25% | ||
warpedpoetic | 0 | 1,441,102,077 | 7.5% | ||
cutemachine | 0 | 10,993,293,774 | 100% | ||
ameliabartlett | 0 | 1,254,938,321 | 7.5% | ||
tdogvoid | 0 | 385,333,944 | 100% | ||
asgarth | 0 | 12,845,206,926 | 100% | ||
viajeradelrio | 0 | 74,396,497 | 25% | ||
dawa | 0 | 103,638,954 | 25% | ||
saidqautsar | 0 | 98,489,062 | 25% | ||
critday | 0 | 6,279,128,934 | 100% | ||
karupanocitizen | 0 | 178,261,186 | 50% | ||
mslifesteem | 0 | 365,567,822 | 100% | ||
anak123 | 0 | 254,624,812 | 25% | ||
zcool | 0 | 187,474,537 | 10% | ||
bit6in | 0 | 90,652,107 | 25% | ||
murhadi9 | 0 | 147,754,896 | 25% | ||
sigmund | 0 | 200,033,670 | 25% | ||
ryuna.siege | 0 | 208,798,494 | 100% | ||
abbasi1986 | 0 | 184,585,514 | 25% | ||
digitaldreamer | 0 | 2,308,664,335 | 50% | ||
beetlevc | 0 | 1,134,630,708 | 2% | ||
loreshapergames | 0 | 11,305,756,674 | 100% | ||
remind-me | 0 | 2,072,171,921 | 100% | ||
msjito | 0 | 243,517,093 | 50% | ||
rosepac | 0 | 1,323,640,220 | 100% | ||
cafelate | 0 | 459,781,118 | 5% | ||
sirwayneweezy | 0 | 98,288,031 | 25% | ||
chanchuy | 0 | 526,012,688 | 100% | ||
penyuteverest | 0 | 99,712,056 | 25% | ||
raghao | 0 | 738,677,047 | 25% | ||
steem.racing | 0 | 1,197,387,378 | 6.91% | ||
alatomz | 0 | 83,528,234 | 25% | ||
aljofer | 0 | 100,242,646 | 25% | ||
steem-ua | 0 | 194,890,149,471 | 1.2% | ||
forhadh | 0 | 100,242,320 | 25% | ||
nfc | 0 | 9,684,671,068 | 1% | ||
curbot | 0 | 3,784,918,663 | 10% | ||
finallynetwork | 0 | 33,567,583,236 | 100% |
#### Hi @sambillingham! Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation! Your **UA** account score is currently 4.496 which ranks you at **#1895** across all Steem accounts. Your rank has improved 2 places in the last three days (old rank 1897). In our last Algorithmic Curation Round, consisting of 291 contributions, your post is ranked at **#238**. ##### Evaluation of your UA score: * Some people are already following you, keep going! * The readers appreciate your great work! * Try to work on user engagement: the more people that interact with you via the comments, the higher your UA score! **Feel free to join our [@steem-ua Discord server](https://discord.gg/KpBNYGz)**
post_id | 63,869,813 |
---|---|
author | steem-ua |
permlink | re-finally-comments-npm-library-platform-fixes-1538948648670-20181008t114733z |
category | utopian-io |
json_metadata | {"app":"beem\/0.20.5"} |
created | 2018-10-08 11:47:33 |
last_update | 2018-10-08 11:47:33 |
depth | 1 |
children | 0 |
net_rshares | 0 |
last_payout | 2018-10-15 11:47:33 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 738 |
author_reputation | 23,203,609,903,979 |
root_title | "Finally Comments NPM Library + Platform - Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
Thanks for the contribution, @sambillingham! It's cool to see you finally have time to fix these bugs. Definitely looking forward to reading more updates about the Finally Network, though π I'm not sure if I understand what the `test/index/html` file is exactly. Everything seems to be commented out, so I'm confused. --- Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/1342214). ---- Need help? Write a ticket on https://support.utopian.io/. Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
post_id | 63,875,798 |
---|---|
author | amosbastian |
permlink | re-sambillingham-finally-comments-npm-library-platform-fixes-1538948648670-20181008t133910434z |
category | utopian-io |
json_metadata | {"app":"steemit\/0.1","tags":["utopian-io"],"users":["sambillingham"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/1342214","https:\/\/support.utopian.io\/","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"]} |
created | 2018-10-08 13:39:09 |
last_update | 2018-10-08 13:39:09 |
depth | 1 |
children | 2 |
net_rshares | 6,378,660,544,759 |
last_payout | 2018-10-15 13:39:09 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 7.110 SBD |
curator_payout_value | 2.307 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 814 |
author_reputation | 174,225,255,912,876 |
root_title | "Finally Comments NPM Library + Platform - Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
sambillingham | 0 | 19,609,429,701 | 100% | ||
codingdefined | 0 | 3,989,168,962 | 5% | ||
espoem | 0 | 9,105,685,936 | 7.5% | ||
utopian-io | 0 | 6,290,013,806,025 | 4.37% | ||
zapncrap | 0 | 1,976,381,149 | 5% | ||
curx | 0 | 1,795,234,075 | 5% | ||
organicgardener | 0 | 1,764,268,200 | 25% | ||
reazuliqbal | 0 | 6,138,112,435 | 10% | ||
hakancelik | 0 | 10,806,482,427 | 30% | ||
mightypanda | 0 | 31,477,041,571 | 30% | ||
fastandcurious | 0 | 1,691,479,786 | 50% | ||
mops2e | 0 | 293,454,492 | 10% |
Thanks Amos. The `test/index` was intended for debugging ad I found myself doing this anyway I left it in there. I shouldn't have left it commented out though π
post_id | 63,982,966 |
---|---|
author | sambillingham |
permlink | re-amosbastian-re-sambillingham-finally-comments-npm-library-platform-fixes-1538948648670-20181010t084204940z |
category | utopian-io |
json_metadata | {"app":"steemit\/0.1","tags":["utopian-io"]} |
created | 2018-10-10 08:42:06 |
last_update | 2018-10-10 08:42:06 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2018-10-17 08:42:06 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 162 |
author_reputation | 34,851,559,982,476 |
root_title | "Finally Comments NPM Library + Platform - Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
Thank you for your review, @amosbastian! So far this week you've reviewed 14 contributions. Keep up the good work!
post_id | 64,175,902 |
---|---|
author | utopian-io |
permlink | re-re-sambillingham-finally-comments-npm-library-platform-fixes-1538948648670-20181008t133910434z-20181013t133129z |
category | utopian-io |
json_metadata | {"app":"beem\/0.20.1"} |
created | 2018-10-13 13:31:30 |
last_update | 2018-10-13 13:31:30 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2018-10-20 13:31:30 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 115 |
author_reputation | 152,913,012,544,965 |
root_title | "Finally Comments NPM Library + Platform - Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
Hey, @sambillingham! **Thanks for contributing on Utopian**. Weβre already looking forward to your next contribution! **Get higher incentives and support Utopian.io!** Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via [SteemPlus](https://chrome.google.com/webstore/detail/steemplus/mjbkjgcplmaneajhcbegoffkedeankaj?hl=en) or [Steeditor](https://steeditor.app)). **Want to chat? Join us on Discord https://discord.gg/h52nFrV.** <a href='https://steemconnect.com/sign/account-witness-vote?witness=utopian-io&approve=1'>Vote for Utopian Witness!</a>
post_id | 64,092,071 |
---|---|
author | utopian-io |
permlink | re-finally-comments-npm-library-platform-fixes-1538948648670-20181012t031014z |
category | utopian-io |
json_metadata | {"app":"beem\/0.20.1"} |
created | 2018-10-12 03:10:15 |
last_update | 2018-10-12 03:10:15 |
depth | 1 |
children | 0 |
net_rshares | 0 |
last_payout | 2018-10-19 03:10:15 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 595 |
author_reputation | 152,913,012,544,965 |
root_title | "Finally Comments NPM Library + Platform - Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |