RE: KURE Development Update 8 - UI/UX Candy, Mobile Menu, Infinite Scroll and Lots of Fixes by helo

View this thread on steempeak.com

Viewing a response to: @krnel/kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes

· @helo ·
$14.39
- Great post with a video, images, code samples and a great layout with plenty of explanations of improvements.
- Good commit comments and separation of concerns, all in one PRs.  Bravo.
- Is it me or is there a lot of dead code in `server/routes/api/steem/upvote.js` and `server/server.js`.  You can take it out, it can always be found in github history.

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/1-2-1-1-1-1-1-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , , , , ,
properties (23)
post_id71,241,470
authorhelo
permlinkre-krnel-kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes-20190311t135628931z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/1-2-1-1-1-1-1-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"}
created2019-03-11 13:56:27
last_update2019-03-11 13:56:27
depth1
children2
net_rshares20,421,167,646,839
last_payout2019-03-18 13:56:27
cashout_time1969-12-31 23:59:59
total_payout_value10.908 SBD
curator_payout_value3.483 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length805
author_reputation119,612,833,307,875
root_title"KURE Development Update 8 - UI/UX Candy, Mobile Menu, Infinite Scroll and Lots of Fixes"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
author_curate_reward""
vote details (17)
@krnel ·
$0.12
Thanks for the review! Yeah, the upvote part was something new I'm working on, and funny thing is I even deleted the folder to not have it included in the PR, but then I undid the delete before the last commit :P instead of undoing it only after I did the commit. I try to remove some large commented areas before committing, but it's cumbersome to do and I forget. The server.js is something I need to finalize instead of leaving the large commented code in there, indeed.
👍  
properties (23)
post_id71,242,579
authorkrnel
permlinkre-helo-re-krnel-kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes-20190311t141848737z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit\/0.1"}
created2019-03-11 14:18:48
last_update2019-03-11 14:18:48
depth2
children0
net_rshares218,433,031,989
last_payout2019-03-18 14:18:48
cashout_time1969-12-31 23:59:59
total_payout_value0.116 SBD
curator_payout_value0.002 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length473
author_reputation954,992,586,021,436
root_title"KURE Development Update 8 - UI/UX Candy, Mobile Menu, Infinite Scroll and Lots of Fixes"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
author_curate_reward""
vote details (1)
@utopian-io ·
Thank you for your review, @helo! Keep up the good work!
properties (22)
post_id71,437,433
authorutopian-io
permlinkre-re-krnel-kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes-20190311t135628931z-20190314t050140z
categoryutopian-io
json_metadata{"app":"beem\/0.20.17"}
created2019-03-14 05:01:42
last_update2019-03-14 05:01:42
depth2
children0
net_rshares0
last_payout2019-03-21 05:01:42
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length56
author_reputation152,913,012,544,965
root_title"KURE Development Update 8 - UI/UX Candy, Mobile Menu, Infinite Scroll and Lots of Fixes"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000