Viewing a response to: @krnel/kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes
- Great post with a video, images, code samples and a great layout with plenty of explanations of improvements. - Good commit comments and separation of concerns, all in one PRs. Bravo. - Is it me or is there a lot of dead code in `server/routes/api/steem/upvote.js` and `server/server.js`. You can take it out, it can always be found in github history. Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/1-2-1-1-1-1-1-). ---- Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
post_id | 71,241,470 |
---|---|
author | helo |
permlink | re-krnel-kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes-20190311t135628931z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/1-2-1-1-1-1-1-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"} |
created | 2019-03-11 13:56:27 |
last_update | 2019-03-11 13:56:27 |
depth | 1 |
children | 2 |
net_rshares | 20,421,167,646,839 |
last_payout | 2019-03-18 13:56:27 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 10.908 SBD |
curator_payout_value | 3.483 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 805 |
author_reputation | 119,612,833,307,875 |
root_title | "KURE Development Update 8 - UI/UX Candy, Mobile Menu, Infinite Scroll and Lots of Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
krnel | 0 | 1,420,267,780,762 | 100% | ||
elviento | 0 | 476,084,103 | 0.88% | ||
codingdefined | 0 | 28,120,174,155 | 20% | ||
espoem | 0 | 26,792,117,628 | 15% | ||
utopian-io | 0 | 18,729,947,992,525 | 13.25% | ||
jaff8 | 0 | 42,823,631,121 | 19.48% | ||
emrebeyler | 0 | 6,351,811,982 | 1% | ||
aydant | 0 | 4,706,740,261 | 50% | ||
amosbastian | 0 | 60,717,289,191 | 19.49% | ||
sargoon | 0 | 1,568,116,747 | 48% | ||
reazuliqbal | 0 | 18,446,976,262 | 10% | ||
statsexpert | 0 | 8,011,156,799 | 100% | ||
sbi6 | 0 | 53,799,553,045 | 46.11% | ||
ulockblock | 0 | 15,216,429,076 | 4.69% | ||
curbot | 0 | 2,512,009,419 | 100% | ||
ascorphat | 0 | 913,619,378 | 2.5% | ||
tenyears | 0 | 496,164,385 | 98% |
Thanks for the review! Yeah, the upvote part was something new I'm working on, and funny thing is I even deleted the folder to not have it included in the PR, but then I undid the delete before the last commit :P instead of undoing it only after I did the commit. I try to remove some large commented areas before committing, but it's cumbersome to do and I forget. The server.js is something I need to finalize instead of leaving the large commented code in there, indeed.
post_id | 71,242,579 |
---|---|
author | krnel |
permlink | re-helo-re-krnel-kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes-20190311t141848737z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"app":"steemit\/0.1"} |
created | 2019-03-11 14:18:48 |
last_update | 2019-03-11 14:18:48 |
depth | 2 |
children | 0 |
net_rshares | 218,433,031,989 |
last_payout | 2019-03-18 14:18:48 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.116 SBD |
curator_payout_value | 0.002 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 473 |
author_reputation | 954,992,586,021,436 |
root_title | "KURE Development Update 8 - UI/UX Candy, Mobile Menu, Infinite Scroll and Lots of Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
helo | 0 | 218,433,031,989 | 100% |
Thank you for your review, @helo! Keep up the good work!
post_id | 71,437,433 |
---|---|
author | utopian-io |
permlink | re-re-krnel-kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes-20190311t135628931z-20190314t050140z |
category | utopian-io |
json_metadata | {"app":"beem\/0.20.17"} |
created | 2019-03-14 05:01:42 |
last_update | 2019-03-14 05:01:42 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2019-03-21 05:01:42 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 56 |
author_reputation | 152,913,012,544,965 |
root_title | "KURE Development Update 8 - UI/UX Candy, Mobile Menu, Infinite Scroll and Lots of Fixes" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |