RE: Simple Video Downloader 3.0.5 - Supporting MSDN and TED ! by amosbastian

Viewing a response to: @justyy/simple-video-downloader-3-0-5-supporting-msdn-and-ted

utopian-io · @amosbastian · Nov 18 '18

$7.67

Thanks for the contribution, @justyy. Since I started working on my own extension it's very interesting to me seeing how others implement theirs. I haven't added any unit tests for mine yet, as to be honest I didn't really have any idea about how to implement them for a browser extension in the first place. I am guessing the HTML files are what are used to test the extension on?

I would recommend using Prettier as there some small inconsistencies (like places where `let` could be replaced by `const`) and Prettier will fix those automatically. Was also wondering if there is a reason why you check if the URL's length > 5 twice ([here](https://github.com/DoctorLai/VideoDownloadHelper/pull/5/files#diff-1370103fe706155835f4cb5e2d648bc8R120) and [here](https://github.com/DoctorLai/VideoDownloadHelper/pull/5/files#diff-1370103fe706155835f4cb5e2d648bc8R125)) - I feel like I am missing something, haha.

Anyway, I might start doing some research about how to add unit tests to my own extension, thanks for the inspiration! Also, it's definitely no small feat to have 14000+ users, really cool!

---

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2222222).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)

👍 utopian-io, mightypanda, justyy, emrebeyler, reazuliqbal, steemtaker, shammi, aydant, organicgardener, fastandcurious

`post_id`	66,219,796
`author`	amosbastian
`permlink`	re-justyy-simple-video-downloader-3-0-5-supporting-msdn-and-ted-20181118t144430478z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"users":["justyy"],"links":["https:\/\/github.com\/DoctorLai\/VideoDownloadHelper\/pull\/5\/files#diff-1370103fe706155835f4cb5e2d648bc8R120","https:\/\/github.com\/DoctorLai\/VideoDownloadHelper\/pull\/5\/files#diff-1370103fe706155835f4cb5e2d648bc8R125","https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/2222222","https:\/\/support.utopian.io\/","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"}
`created`	2018-11-18 14:44:30
`last_update`	2018-11-18 14:44:30
`depth`	1
`children`	2
`net_rshares`	12,106,499,642,782
`last_payout`	2018-11-25 14:44:30
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	5.799 SBD
`curator_payout_value`	1.869 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	1,594
`author_reputation`	174,225,255,912,876
`root_title`	"Simple Video Downloader 3.0.5 - Supporting MSDN and TED !"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000
`author_curate_reward`	""

properties (23)vote details (10)

voter	rshares	pct
justyy	18,752,400,489	1%
utopian-io	11,985,430,405,707	8.33%
shammi	6,519,401,178	7%
emrebeyler	15,602,009,588	1%
steemtaker	6,752,125,589	6%
aydant	4,897,257,084	50%
organicgardener	4,771,870,475	25%
reazuliqbal	9,619,034,014	8%
mightypanda	52,968,966,604	35%
fastandcurious	1,186,172,054	30%

@justyy · Nov 18 '18

Thanks for the review and yes I'll definitely checkout the Prettier.. To be honest, I am not a front-end developer and I hardly catch up the latest frontend frameworks. I use `mocha` and `chai` to unit tests the core JS classes and use `webpack` to pack the ES6 to something Chrome understands e.g. Chrome extension does not understand `require`. Yes, you are right with Length>5 - which is obviously a code smell and I'll fix that later.

👍 dailychina, dailystats, turtlegraphics, witnesstools, ilovecoding, superbing, steemfuckeos, happyukgo, dailyfortune

`post_id`	66,224,212
`author`	justyy
`permlink`	re-amosbastian-re-justyy-simple-video-downloader-3-0-5-supporting-msdn-and-ted-20181118t161525803z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"app":"steemit\/0.1"}
`created`	2018-11-18 16:15:27
`last_update`	2018-11-18 16:15:27
`depth`	2
`children`	0
`net_rshares`	21,064,028,499
`last_payout`	2018-11-25 16:15:27
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 SBD
`curator_payout_value`	0.000 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	438
`author_reputation`	2,068,023,909,501,151
`root_title`	"Simple Video Downloader 3.0.5 - Supporting MSDN and TED !"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000
`author_curate_reward`	""

properties (23)vote details (9)

voter	rshares	pct
happyukgo	480,535,525	25%
superbing	1,897,202,578	25%
dailyfortune	31,679,755	25%
dailystats	5,107,365,517	25%
dailychina	5,294,016,751	25%
turtlegraphics	2,361,402,070	25%
witnesstools	2,276,429,539	25%
ilovecoding	2,141,238,920	25%
steemfuckeos	1,474,157,844	25%

@utopian-io · Nov 21 '18

Thank you for your review, @amosbastian! Keep up the good work!

properties (22)

`post_id`	66,354,204
`author`	utopian-io
`permlink`	re-re-justyy-simple-video-downloader-3-0-5-supporting-msdn-and-ted-20181118t144430478z-20181121t021643z
`category`	utopian-io
`json_metadata`	{"app":"beem\/0.20.9"}
`created`	2018-11-21 02:16:45
`last_update`	2018-11-21 02:16:45
`depth`	2
`children`	0
`net_rshares`	0
`last_payout`	2018-11-28 02:16:45
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 SBD
`curator_payout_value`	0.000 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	63
`author_reputation`	152,913,012,544,965
`root_title`	"Simple Video Downloader 3.0.5 - Supporting MSDN and TED !"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000