RE: [Boxwise - fair donations distribution to refugees] Generating packages in bulk - new feature by amosbastian

View this thread on steempeak.com

Viewing a response to: @matkodurko/boxwise-fair-donations-distribution-to-refugees-generating-packages-in-bulk-new-feature

· @amosbastian ·
$14.97
Sounds like a very interesting project (with a great goal) - it's really great to see projects like this on here! Your way of describing the steps you went through to add this feature resulted in a very interesting read (and funny - the 380 pages PDF sounds daunting lol). Also the picture of the workflow and the added GIFs really made it easy to understand what you actually implemented - great work with that.

Since I have never used Odoo myself, I don't really have any feedback to give about that, but here are some thoughts about the code:

* [This](https://github.com/boxwise/boxwise_wms/blob/992f74131ffc63e3b8579735ab640cff1a479843/wizards/generate_qr_count_wizard.py#L19-L22) can be converted to a one-liner (list comprehension) `created_packages = [package_model.create({}) for _ in range(number_of_packages)]`.

I'm definitely looking forward to seeing more contributions to this project!

---

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/1-2-2-2-1-1-3-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , , , , , ,
properties (23)
post_id70,409,746
authoramosbastian
permlinkre-matkodurko-boxwise-fair-donations-distribution-to-refugees-generating-packages-in-bulk-new-feature-20190220t154731284z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https:\/\/github.com\/boxwise\/boxwise_wms\/blob\/992f74131ffc63e3b8579735ab640cff1a479843\/wizards\/generate_qr_count_wizard.py#L19-L22","https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/1-2-2-2-1-1-3-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"}
created2019-02-20 15:47:30
last_update2019-02-20 15:47:30
depth1
children2
net_rshares28,342,020,123,210
last_payout2019-02-27 15:47:30
cashout_time1969-12-31 23:59:59
total_payout_value11.308 SBD
curator_payout_value3.660 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length1,356
author_reputation174,225,255,912,876
root_title"[Boxwise - fair donations distribution to refugees] Generating packages in bulk - new feature"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
author_curate_reward""
vote details (18)
@matkodurko · (edited)
Hmm nice, I'll add that one liner next time I'll be editing that file (which will be soon as we want to automatically download the pdf with those QR codes)..

And regarding Odoo...I'm not really too happy with it, I've searched a bit and it doesn't seem to be widely used ...so there won't be a huuuge benefit from being familiar with it...but yeah, that warehouse management module which is already implemented for Odoo comes in handy and saved us lot of work.

Edit: Also, thx for the review! :D
properties (22)
post_id70,410,555
authormatkodurko
permlinkre-amosbastian-re-matkodurko-boxwise-fair-donations-distribution-to-refugees-generating-packages-in-bulk-new-feature-20190220t160310922z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"app":"steemit\/0.1"}
created2019-02-20 16:03:12
last_update2019-02-20 16:16:30
depth2
children0
net_rshares0
last_payout2019-02-27 16:03:12
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length497
author_reputation37,728,250,474,469
root_title"[Boxwise - fair donations distribution to refugees] Generating packages in bulk - new feature"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
@utopian-io ·
Thank you for your review, @amosbastian! Keep up the good work!
properties (22)
post_id70,508,614
authorutopian-io
permlinkre-re-matkodurko-boxwise-fair-donations-distribution-to-refugees-generating-packages-in-bulk-new-feature-20190220t154731284z-20190222t225129z
categoryutopian-io
json_metadata{"app":"beem\/0.20.17"}
created2019-02-22 22:51:30
last_update2019-02-22 22:51:30
depth2
children0
net_rshares0
last_payout2019-03-01 22:51:30
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length63
author_reputation152,913,012,544,965
root_title"[Boxwise - fair donations distribution to refugees] Generating packages in bulk - new feature"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000