RE: Minecolonies & Waypoints & Tons of Fixes by helo

Viewing a response to: @raycoms/minecolonies-and-waypoints-and-tons-of-fixes

utopian-io · @helo · Jul 17 '18

$0.03

* Great work, beautiful code.
* Did that issue get resolved?
> `return OreDictionary.itemMatches(getStack(), stack, matchMeta);`
> Please revert this Change. This contraticts the other behaviour of Stack.


Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/1211111).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)

👍 raycoms, espoem, mops2e

`post_id`	56,850,136
`author`	helo
`permlink`	re-raycoms-minecolonies-and-waypoints-and-tons-of-fixes-20180717t173022840z
`category`	utopian-io
`json_metadata`	{"app":"steemit\/0.1","tags":["utopian-io"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/1211111","https:\/\/support.utopian.io\/","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"]}
`created`	2018-07-17 17:30:21
`last_update`	2018-07-17 17:30:21
`depth`	1
`children`	3
`net_rshares`	16,394,068,463
`last_payout`	2018-07-24 17:30:21
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.026 SBD
`curator_payout_value`	0.007 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	696
`author_reputation`	119,612,833,307,875
`root_title`	"Minecolonies & Waypoints & Tons of Fixes"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000
`author_curate_reward`	""

properties (23)vote details (3)

voter	rshares	pct
raycoms	10,503,758,188	5%
espoem	5,838,392,836	5%
mops2e	51,917,439	55%

@raycoms · Jul 17 '18

$0.05

Yeah, we discussed this over Discord.
The function has two possible returns, and the second return was already matching it independent of the stack size, and he hadn't seen that.

👍 helo

`post_id`	56,860,432
`author`	raycoms
`permlink`	re-helo-re-raycoms-minecolonies-and-waypoints-and-tons-of-fixes-20180717t193514306z
`category`	utopian-io
`json_metadata`	{"tags":["utopian-io"],"app":"steemit\/0.1"}
`created`	2018-07-17 19:35:15
`last_update`	2018-07-17 19:35:15
`depth`	2
`children`	2
`net_rshares`	22,159,149,771
`last_payout`	2018-07-24 19:35:15
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.045 SBD
`curator_payout_value`	0.000 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	178
`author_reputation`	120,534,427,956,805
`root_title`	"Minecolonies & Waypoints & Tons of Fixes"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000
`author_curate_reward`	""

properties (23)vote details (1)

voter	weight	wgt%	rshares	pct	time
helo	0 B		22,159,149,771	100%

@helo · Jul 17 '18

Great work as always. Keep them coming, they’re a joy to review.

properties (22)

`post_id`	56,860,728
`author`	helo
`permlink`	re-raycoms-re-helo-re-raycoms-minecolonies-and-waypoints-and-tons-of-fixes-20180717t193909878z
`category`	utopian-io
`json_metadata`	{"format":"markdown","links":[],"tags":["utopian-io"],"community":"busy","users":[],"image":[],"app":"busy\/2.5.3"}
`created`	2018-07-17 19:39:12
`last_update`	2018-07-17 19:39:12
`depth`	3
`children`	1
`net_rshares`	0
`last_payout`	2018-07-24 19:39:12
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 SBD
`curator_payout_value`	0.000 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	65
`author_reputation`	119,612,833,307,875
`root_title`	"Minecolonies & Waypoints & Tons of Fixes"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000

@raycoms · Jul 18 '18

Thanks, I'm always glad to get some time to work on this project.
It's starting to get really exciting because it's getting really stable and really close to a propper release.

properties (22)

`post_id`	56,879,072
`author`	raycoms
`permlink`	re-helo-re-raycoms-re-helo-re-raycoms-minecolonies-and-waypoints-and-tons-of-fixes-20180718t000520861z
`category`	utopian-io
`json_metadata`	{"app":"steemit\/0.1","tags":["utopian-io"]}
`created`	2018-07-18 00:05:21
`last_update`	2018-07-18 00:05:21
`depth`	4
`children`	0
`net_rshares`	0
`last_payout`	2018-07-25 00:05:21
`cashout_time`	1969-12-31 23:59:59
`total_payout_value`	0.000 SBD
`curator_payout_value`	0.000 SBD
`pending_payout_value`	0.000 SBD
`promoted`	0.000 SBD
`body_length`	176
`author_reputation`	120,534,427,956,805
`root_title`	"Minecolonies & Waypoints & Tons of Fixes"
`beneficiaries`	`[]`
`max_accepted_payout`	1,000,000.000 SBD
`percent_steem_dollars`	10,000