Viewing a response to: @beggars/utopian-task-completion-steem-editor
Thank you @beggars for your contribution. In theory, the dist/ files js/css are not meant to be uploaded (instead, they are generated via webpack) but I can see this is not your fault. Some files contain Chinese comments and some comments containing license are removed - not sure this is what intended. Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-3-2-2-2-1-2-). ---- Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
post_id | 70,533,615 |
---|---|
author | justyy |
permlink | re-beggars-utopian-task-completion-steem-editor-20190223t150911954z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"users":["beggars"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/2-3-2-2-2-1-2-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"} |
created | 2019-02-23 15:09:15 |
last_update | 2019-02-23 15:09:15 |
depth | 1 |
children | 1 |
net_rshares | 251,345,866,448 |
last_payout | 2019-03-02 15:09:15 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.113 SBD |
curator_payout_value | 0.021 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 754 |
author_reputation | 2,132,499,258,792,665 |
root_title | "Utopian Task Completion: Steem Editor" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
happyukgo | 0 | 485,829,008 | 25% | ||
codingdefined | 0 | 27,254,994,364 | 20% | ||
superbing | 0 | 2,385,992,268 | 25% | ||
dailyfortune | 0 | 32,467,873 | 25% | ||
dailystats | 0 | 6,958,613,768 | 25% | ||
jaff8 | 0 | 54,864,010,526 | 24.51% | ||
amosbastian | 0 | 73,969,566,026 | 24.51% | ||
sargoon | 0 | 1,047,551,213 | 100% | ||
dailychina | 0 | 6,572,146,957 | 25% | ||
beggars | 0 | 22,007,441,542 | 100% | ||
reazuliqbal | 0 | 18,265,352,897 | 10% | ||
turtlegraphics | 0 | 2,378,103,873 | 25% | ||
ulockblock | 0 | 8,075,068,315 | 4.37% | ||
witnesstools | 0 | 2,288,063,944 | 25% | ||
ilovecoding | 0 | 2,275,478,747 | 25% | ||
curbot | 0 | 2,409,153,776 | 100% | ||
steemfuckeos | 0 | 1,483,515,219 | 25% | ||
yff | 0 | 18,335,810,040 | 100% | ||
curatortrail | 0 | 256,706,092 | 80% | ||
pedronel | 0 | 0 | 11% |
Hi justyy, Thanks for the feedback. Correct, built files were already being shipped in the package. I believe the reason for doing this is to allow the Git repository itself to be installable without needing Npm. Chinese comments were a prior artefact, in some cases, they were not needed. The text at the top of the Webpack file was removed, as it is an entirely new file. Going from Webpack 2 to 4, the differences were so great I started new files from scratch and gradually ported loaders and config options. Webpack configuration files should be mostly undocumented, as they're expressive and implicit already (following documented conventions). Only specific instances like chunk configuration and other complex things should be commented, I believe. Everyone has their personal preference. The existing comment at the top was also too detailed. Git is intended to show you who and when a file was changed, so much of the prior information was redundant. Configuration files also do not fall under copyright, as they're not unique. As per MIT licence requirements, a LICENSE file exists in the root of the repository with the licence in question. A comment with copyright notice is not a requirement under the MIT licence, it's one of the most "open" open source licences out there (I love it). Thanks again. Nice thorough review. You're doing a great job for @utopian-io
post_id | 70,547,474 |
---|---|
author | beggars |
permlink | beggars-re-justyy-re-beggars-utopian-task-completion-steem-editor-20190223t235801976z |
category | utopian-io |
json_metadata | {"app":"steemit\/0.1","client":"android","tags":["utopian-io"],"users":["utopian-io"]} |
created | 2019-02-23 23:58:03 |
last_update | 2019-02-24 00:58:06 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2019-03-02 23:58:03 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 1,384 |
author_reputation | 21,821,715,475,664 |
root_title | "Utopian Task Completion: Steem Editor" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |