RE: Product API implementation into the PHP Client for Makerlog by justyy

View this thread on steempeak.com

Viewing a response to: @dehenne/product-api-implementation-into-the-php-client-for-makerlog

· @justyy ·
$10.20
Thank you for your contribution. You probably want to take a look at [Rest API Design](https://www.mulesoft.com/resources/api/what-is-rest-api-design).

1. [this line](https://github.com/pcsg/pcsg-makerlog-php-client/commit/47452cb0fe7675baab284a5771dc79d6c7ac0391#diff-f0c722a0daf1037815467c8e1c129611R11) seems duplicate.
2. Your `getProductData` has been called in its many APIs to get the sub-field which may be cached.
3. The `getData` and many other APIs has a long chain in getting its field data, which may throw exception e.g. null pointer. The try-catch will hide the errors and prevent early identification of the risks - which is generally a bad idea.
4. When performing `addUserToTheTeam`, have you thought about multiple requests i.e. race conditions?

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-2-2-2-2-2-1-).

---- 
Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm).

[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , , , , , , , , ,
properties (23)
post_id71,767,929
authorjustyy
permlinkre-dehenne-product-api-implementation-into-the-php-client-for-makerlog-20190320t220927116z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"links":["https:\/\/www.mulesoft.com\/resources\/api\/what-is-rest-api-design","https:\/\/github.com\/pcsg\/pcsg-makerlog-php-client\/commit\/47452cb0fe7675baab284a5771dc79d6c7ac0391#diff-f0c722a0daf1037815467c8e1c129611R11","https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/2-2-2-2-2-2-1-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"}
created2019-03-20 22:09:30
last_update2019-03-20 22:09:30
depth1
children1
net_rshares15,694,498,694,430
last_payout2019-03-27 22:09:30
cashout_time1969-12-31 23:59:59
total_payout_value7.740 SBD
curator_payout_value2.463 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length1,215
author_reputation2,068,023,909,501,151
root_title"Product API implementation into the PHP Client for Makerlog"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
author_curate_reward""
vote details (21)
@utopian-io ·
Thank you for your review, @justyy! Keep up the good work!
properties (22)
post_id71,912,272
authorutopian-io
permlinkre-re-dehenne-product-api-implementation-into-the-php-client-for-makerlog-20190320t220927116z-20190323t122258z
categoryutopian-io
json_metadata{"app":"beem\/0.20.17"}
created2019-03-23 12:23:00
last_update2019-03-23 12:23:00
depth2
children0
net_rshares0
last_payout2019-03-30 12:23:00
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length58
author_reputation152,913,012,544,965
root_title"Product API implementation into the PHP Client for Makerlog"
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000