Viewing a response to: @dehenne/product-api-implementation-into-the-php-client-for-makerlog
Thank you for your contribution. You probably want to take a look at [Rest API Design](https://www.mulesoft.com/resources/api/what-is-rest-api-design). 1. [this line](https://github.com/pcsg/pcsg-makerlog-php-client/commit/47452cb0fe7675baab284a5771dc79d6c7ac0391#diff-f0c722a0daf1037815467c8e1c129611R11) seems duplicate. 2. Your `getProductData` has been called in its many APIs to get the sub-field which may be cached. 3. The `getData` and many other APIs has a long chain in getting its field data, which may throw exception e.g. null pointer. The try-catch will hide the errors and prevent early identification of the risks - which is generally a bad idea. 4. When performing `addUserToTheTeam`, have you thought about multiple requests i.e. race conditions? Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category. To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/2-2-2-2-2-2-1-). ---- Need help? Chat with us on [Discord](https://discord.gg/uTyJkNm). [[utopian-moderator]](https://join.utopian.io/)
post_id | 71,767,929 |
---|---|
author | justyy |
permlink | re-dehenne-product-api-implementation-into-the-php-client-for-makerlog-20190320t220927116z |
category | utopian-io |
json_metadata | {"tags":["utopian-io"],"links":["https:\/\/www.mulesoft.com\/resources\/api\/what-is-rest-api-design","https:\/\/github.com\/pcsg\/pcsg-makerlog-php-client\/commit\/47452cb0fe7675baab284a5771dc79d6c7ac0391#diff-f0c722a0daf1037815467c8e1c129611R11","https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/2-2-2-2-2-2-1-","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"} |
created | 2019-03-20 22:09:30 |
last_update | 2019-03-20 22:09:30 |
depth | 1 |
children | 1 |
net_rshares | 15,694,498,694,430 |
last_payout | 2019-03-27 22:09:30 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 7.740 SBD |
curator_payout_value | 2.463 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 1,215 |
author_reputation | 2,068,023,909,501,151 |
root_title | "Product API implementation into the PHP Client for Makerlog" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |
author_curate_reward | "" |
voter | weight | wgt% | rshares | pct | time |
---|---|---|---|---|---|
happyukgo | 0 | 502,497,807 | 25% | ||
mys | 0 | 762,224,128 | 0.6% | ||
codingdefined | 0 | 28,500,208,493 | 20.5% | ||
superbing | 0 | 2,537,159,729 | 25% | ||
dailyfortune | 0 | 35,029,302 | 25% | ||
espoem | 0 | 30,444,876,922 | 15% | ||
dailystats | 0 | 7,392,208,083 | 25% | ||
utopian-io | 0 | 15,445,529,758,662 | 11.07% | ||
jaff8 | 0 | 48,912,880,318 | 20.5% | ||
amosbastian | 0 | 71,111,140,041 | 20.5% | ||
dailychina | 0 | 7,009,259,067 | 25% | ||
reazuliqbal | 0 | 13,663,249,782 | 8% | ||
amico | 0 | 1,098,863,290 | 0.6% | ||
turtlegraphics | 0 | 2,397,130,416 | 25% | ||
ulockblock | 0 | 23,204,400,121 | 7.28% | ||
witnesstools | 0 | 2,310,978,430 | 25% | ||
ilovecoding | 0 | 2,293,168,823 | 25% | ||
curbot | 0 | 2,500,495,461 | 100% | ||
steemfuckeos | 0 | 1,495,319,794 | 25% | ||
ascorphat | 0 | 2,295,832,621 | 2.5% | ||
cleanit | 0 | 502,013,140 | 100% |
Thank you for your review, @justyy! Keep up the good work!
post_id | 71,912,272 |
---|---|
author | utopian-io |
permlink | re-re-dehenne-product-api-implementation-into-the-php-client-for-makerlog-20190320t220927116z-20190323t122258z |
category | utopian-io |
json_metadata | {"app":"beem\/0.20.17"} |
created | 2019-03-23 12:23:00 |
last_update | 2019-03-23 12:23:00 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2019-03-30 12:23:00 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 58 |
author_reputation | 152,913,012,544,965 |
root_title | "Product API implementation into the PHP Client for Makerlog" |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |