RE: [Aristotle App] Add Contribution, Weekly LM Reports and more... by amosbastian

View this thread on steempeak.com

Viewing a response to: @dimitrisp/aristotle-app-add-contribution-weekly-lm-reports-and-more

· @amosbastian · (edited)
$10.07
Thanks for the contribution, @dimitrisp! It's very cool to see the effort you are putting in to keep the Greek translation team running as smoothly as possible - great stuff!

As for the review; I think there are some places like `IsSteemLink` where you could use a regex to see if it's valid, and then split it by groups to get the information you need. Not really important though, just thought I'd mention it.

In some places there are magic numbers, like for example `$hasaccess == 2`. What is 2? I personally would define some constants and use those instead, which should improve the readability of the code.

The commit messages are already great, so my only suggestion is that you should try and keep the subject a bit shorter. Around 50 characters is normally the recommended number.

As it was already mentioned by @codingdefined and you said you are already working on it, I won't comment on the number of nested if statements haha.

Looking forward to seeing what other great features you add - it's really coming along nicely! P.S. you should making think about using pull requests, as it will save you some effort in linking all the commits (I know how tedious that is, haha).

---

Your contribution has been evaluated according to [Utopian policies and guidelines](https://join.utopian.io/guidelines), as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, [click here](https://review.utopian.io/result/3/1222222).

---- 
Need help? Write a ticket on https://support.utopian.io/. 
Chat with us on [Discord](https://discord.gg/uTyJkNm). 
[[utopian-moderator]](https://join.utopian.io/)
👍  , , , , , , , , , , , , ,
properties (23)
post_id65,118,931
authoramosbastian
permlinkre-dimitrisp-aristotle-app-add-contribution-weekly-lm-reports-and-more-20181029t113613381z
categoryutopian-io
json_metadata{"tags":["utopian-io"],"users":["dimitrisp","codingdefined"],"links":["https:\/\/join.utopian.io\/guidelines","https:\/\/review.utopian.io\/result\/3\/1222222","https:\/\/support.utopian.io\/","https:\/\/discord.gg\/uTyJkNm","https:\/\/join.utopian.io\/"],"app":"steemit\/0.1"}
created2018-10-29 11:36:12
last_update2018-10-29 11:43:51
depth1
children2
net_rshares8,650,376,042,026
last_payout2018-11-05 11:36:12
cashout_time1969-12-31 23:59:59
total_payout_value7.636 SBD
curator_payout_value2.437 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length1,686
author_reputation174,225,255,912,876
root_title"[Aristotle App] Add Contribution, Weekly LM Reports and more..."
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
author_curate_reward""
vote details (14)
@dimitrisp ·
> I think there are some places like IsSteemLink where you could use a regex to see if it's valid, and then split it by groups to get the information you need

Yeah that's probably how I'm going to handle this

> In some places there are magic numbers, like for example $hasaccess == 2. What is 2? I personally would define some constants and use those instead, which should improve the readability of the code.

I know it is a bad way to do this, but those magic numbers are access levels, and I'm still designing the whole concept in my mind, so I'll fix it soon.

Thank you for all the suggestions @amosbastian, I really enjoyed your review, and I'll do my best to make this software as great as possible, as it will be a great help to use it! :)
properties (22)
post_id65,123,352
authordimitrisp
permlinkre-amosbastian-re-dimitrisp-aristotle-app-add-contribution-weekly-lm-reports-and-more-20181029t130659466z
categoryutopian-io
json_metadata{"users":["amosbastian"],"tags":["utopian-io"],"app":"steemit\/0.1"}
created2018-10-29 13:06:57
last_update2018-10-29 13:06:57
depth2
children0
net_rshares0
last_payout2018-11-05 13:06:57
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length749
author_reputation74,131,024,130,091
root_title"[Aristotle App] Add Contribution, Weekly LM Reports and more..."
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000
@utopian-io ·
Thank you for your review, @amosbastian! Keep up the good work!
properties (22)
post_id65,340,502
authorutopian-io
permlinkre-re-dimitrisp-aristotle-app-add-contribution-weekly-lm-reports-and-more-20181029t113613381z-20181102t032043z
categoryutopian-io
json_metadata{"app":"beem\/0.20.9"}
created2018-11-02 03:20:45
last_update2018-11-02 03:20:45
depth2
children0
net_rshares0
last_payout2018-11-09 03:20:45
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length63
author_reputation152,913,012,544,965
root_title"[Aristotle App] Add Contribution, Weekly LM Reports and more..."
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000