Viewing a response to: @amosbastian/re-dimitrisp-aristotle-app-add-contribution-weekly-lm-reports-and-more-20181029t113613381z
> I think there are some places like IsSteemLink where you could use a regex to see if it's valid, and then split it by groups to get the information you need Yeah that's probably how I'm going to handle this > In some places there are magic numbers, like for example $hasaccess == 2. What is 2? I personally would define some constants and use those instead, which should improve the readability of the code. I know it is a bad way to do this, but those magic numbers are access levels, and I'm still designing the whole concept in my mind, so I'll fix it soon. Thank you for all the suggestions @amosbastian, I really enjoyed your review, and I'll do my best to make this software as great as possible, as it will be a great help to use it! :)
post_id | 65,123,352 |
---|---|
author | dimitrisp |
permlink | re-amosbastian-re-dimitrisp-aristotle-app-add-contribution-weekly-lm-reports-and-more-20181029t130659466z |
category | utopian-io |
json_metadata | {"users":["amosbastian"],"tags":["utopian-io"],"app":"steemit\/0.1"} |
created | 2018-10-29 13:06:57 |
last_update | 2018-10-29 13:06:57 |
depth | 2 |
children | 0 |
net_rshares | 0 |
last_payout | 2018-11-05 13:06:57 |
cashout_time | 1969-12-31 23:59:59 |
total_payout_value | 0.000 SBD |
curator_payout_value | 0.000 SBD |
pending_payout_value | 0.000 SBD |
promoted | 0.000 SBD |
body_length | 749 |
author_reputation | 74,131,024,130,091 |
root_title | "[Aristotle App] Add Contribution, Weekly LM Reports and more..." |
beneficiaries | [] |
max_accepted_payout | 1,000,000.000 SBD |
percent_steem_dollars | 10,000 |