RE: [Aristotle App] Add Contribution, Weekly LM Reports and more... by dimitrisp

View this thread on steempeak.com

Viewing a response to: @amosbastian/re-dimitrisp-aristotle-app-add-contribution-weekly-lm-reports-and-more-20181029t113613381z

· @dimitrisp ·
> I think there are some places like IsSteemLink where you could use a regex to see if it's valid, and then split it by groups to get the information you need

Yeah that's probably how I'm going to handle this

> In some places there are magic numbers, like for example $hasaccess == 2. What is 2? I personally would define some constants and use those instead, which should improve the readability of the code.

I know it is a bad way to do this, but those magic numbers are access levels, and I'm still designing the whole concept in my mind, so I'll fix it soon.

Thank you for all the suggestions @amosbastian, I really enjoyed your review, and I'll do my best to make this software as great as possible, as it will be a great help to use it! :)
properties (22)
post_id65,123,352
authordimitrisp
permlinkre-amosbastian-re-dimitrisp-aristotle-app-add-contribution-weekly-lm-reports-and-more-20181029t130659466z
categoryutopian-io
json_metadata{"users":["amosbastian"],"tags":["utopian-io"],"app":"steemit\/0.1"}
created2018-10-29 13:06:57
last_update2018-10-29 13:06:57
depth2
children0
net_rshares0
last_payout2018-11-05 13:06:57
cashout_time1969-12-31 23:59:59
total_payout_value0.000 SBD
curator_payout_value0.000 SBD
pending_payout_value0.000 SBD
promoted0.000 SBD
body_length749
author_reputation74,131,024,130,091
root_title"[Aristotle App] Add Contribution, Weekly LM Reports and more..."
beneficiaries[]
max_accepted_payout1,000,000.000 SBD
percent_steem_dollars10,000